Just as the error says, you didn't initialize the variable player.

There are 2 ways you can do this depending on who you want to give the perk to.

All Players:

Spoiler: click to open...

function shootables_done()
{
	self waittill(level.shootablesCollected >= level.shootablesNeeded);

	while(1)
	{
		if(level.shootablesCollected == level.shootablesNeeded)
		{
			players = GetPlayers();

			// What ever code you want to execute once all shootables are collected
			IPrintLn("Here is your reward!");

			for(i=0; i < players.size; i++)
			{
				players[i] zm_perks::give_perk( PERK_ELECTRIC_CHERRY, false );
			}

            break;
		}
	}
}

[close]

Only the players that shot a shootable:
First, go into each of the shootable functions and change them to this:

Spoiler: click to open...

function shootable_1()
{
    trig_1 = GetEnt("shootable_trig", "targetname");
	model_1 = GetEnt("shootable_model", "targetname");

	trig_1 SetHintString("");
	trig_1 SetCursorHint("HINT_NOICON");

	while(1)
	{
		trig_1 waittill("trigger", player);

		level.shootablesCollected++;

		IPrintLn("Trigger 1 Shot"); // Not Needed

		thread shootables_done(player);

		break;
	}

	trig_1 Delete();
	model_1 Delete();
}

function shootable_2()
{
    trig_2 = GetEnt("shootable_trig_2", "targetname");
	model_2 = GetEnt("shootable_model_2", "targetname");

	trig_2 SetHintString("");
	trig_2 SetCursorHint("HINT_NOICON");

	while(1)
	{
		trig_2 waittill("trigger", player);

		level.shootablesCollected++;

		IPrintLn("Trigger 2 Shot"); // Not Needed

		thread shootables_done(player);

		break;
	}

	trig_2 Delete();
	model_2 Delete();
}

[close]

then change the shootables_done function to this:

Spoiler: click to open...

function shootables_done(player)
{
	while(1)
	{
		self waittill(level.shootablesCollected >= level.shootablesNeeded);

		if(level.shootablesCollected == level.shootablesNeeded)
		{
			// What ever code you want to execute once all shootables are collected
			IPrintLn("All Shootables Collected");

			player zm_perks::give_perk( PERK_ELECTRIC_CHERRY, false );

		    break;
		}
	}
}

[close]

Thanks but I have try to use the "All Players" script but I got this error when I launching the game :
(Image removed from quote.)

I've already seen this being talked about. I'm very very new to all this and was wondering how I'd go about making this script open a door if anyone can help me this would mean a lot to me and others.   

function init()
{
	level.shootablesNeeded = 3;
	level.shootablesCollected = 0;

	level thread shootable_1();
	level thread shootable_2();
        level thread shootable_3();
}


function shootable_1()
{
    trig_1 = GetEnt("shootable_trig_1", "targetname");
	model_1 = GetEnt("shootable_model_1", "targetname");

	trig_1 SetHintString("");
	trig_1 SetCursorHint("HINT_NOICON");

	while(1)
	{
		trig_1 waittill("trigger");

		level.shootablesCollected++;

		IPrintLn("Trigger 1 Shot"); // Not Needed

		thread shootables_done();

		break;
	}

	trig_1 Delete();
	model_1 Delete();
}

function shootable_2()
{
	trig_2 = GetEnt("shootable_trig_2", "targetname");
	model_2 = GetEnt("shootable_model_2", "targetname");

	trig_2 SetHintString("");
	trig_2 SetCursorHint("HINT_NOICON");

	while(1)
	{
		trig_2 waittill("trigger");

		level.shootablesCollected++;

		IPrintLn("Trigger 2 Shot"); // Not Needed

		thread shootables_done();

		break;
	}

	trig_2 Delete();
	model_2 Delete();
}
function shootable_3()
{
    trig_3 = GetEnt("shootable_trig_3", "targetname");
	model_3 = GetEnt("shootable_model_3", "targetname");

	trig_3 SetHintString("");
	trig_3 SetCursorHint("HINT_NOICON");

	while(1)
	{
		trig_3 waittill("trigger");

		level.shootablesCollected++;

		IPrintLn("Trigger 1 Shot"); // Not Needed

		thread shootables_done();

		break;
	}

	trig_3 Delete();
	model_3 Delete();
}



function shootables_done()
{
door_power = GetEnt("door_power", "targetname");
	while(1)
	{
self waittill(level.shootablesCollected >= level.shootablesNeeded);

if(level.shootablesCollected == level.shootablesNeeded)
{
             door_power MoveZ(-100, 5);

             wait 5;

             door_power Delete();

		        break;
		}
	}
}

function init()
{
	level.shootablesNeeded = 3;
	level.shootablesCollected = 0;

	level thread shootable_1();
	level thread shootable_2();
        level thread shootable_3();
}


function shootable_1()
{
    trig_1 = GetEnt("shootable_trig_1", "targetname");
	model_1 = GetEnt("shootable_model_1", "targetname");

	trig_1 SetHintString("");
	trig_1 SetCursorHint("HINT_NOICON");

	while(1)
	{
		trig_1 waittill("trigger");

		level.shootablesCollected++;

		IPrintLn("Trigger 1 Shot"); // Not Needed

		thread shootables_done();

		break;
	}

	trig_1 Delete();
	model_1 Delete();
}

function shootable_2()
{
	trig_2 = GetEnt("shootable_trig_2", "targetname");
	model_2 = GetEnt("shootable_model_2", "targetname");

	trig_2 SetHintString("");
	trig_2 SetCursorHint("HINT_NOICON");

	while(1)
	{
		trig_2 waittill("trigger");

		level.shootablesCollected++;

		IPrintLn("Trigger 2 Shot"); // Not Needed

		thread shootables_done();

		break;
	}

	trig_2 Delete();
	model_2 Delete();
}
function shootable_3()
{
    trig_3 = GetEnt("shootable_trig_3", "targetname");
	model_3 = GetEnt("shootable_model_3", "targetname");

	trig_3 SetHintString("");
	trig_3 SetCursorHint("HINT_NOICON");

	while(1)
	{
		trig_3 waittill("trigger");

		level.shootablesCollected++;

		IPrintLn("Trigger 1 Shot"); // Not Needed

		thread shootables_done();

		break;
	}

	trig_3 Delete();
	model_3 Delete();
}



function shootables_done()
{
door_power = GetEnt("door_power", "targetname");
	while(1)
	{
self waittill(level.shootablesCollected >= level.shootablesNeeded);

if(level.shootablesCollected == level.shootablesNeeded)
{
             door_power MoveZ(-100, 5);

             wait 5;

             door_power Delete();

		        break;
		}
	}
}

Haven't test this but it should work. Just do reckfullies tutoral at the top of the forum and just add one more script model with a targetname "shootable_model_3" and a trigger damage with the targetname "shootable_trig_3" then add your door make it a  script modle and add the targetname "door_power".  Finally, this should work but it will not say your entering the zone so if you want zombies to spawn in your power room you might have to have someone easle help you with that.

function init()
{
	level.shootablesNeeded = 3;
	level.shootablesCollected = 0;

	level thread shootable_1();
	level thread shootable_2();
        level thread shootable_3();
}


function shootable_1()
{
    trig_1 = GetEnt("shootable_trig_1", "targetname");
	model_1 = GetEnt("shootable_model_1", "targetname");

	trig_1 SetHintString("");
	trig_1 SetCursorHint("HINT_NOICON");

	while(1)
	{
		trig_1 waittill("trigger");

		level.shootablesCollected++;

		IPrintLn("Trigger 1 Shot"); // Not Needed

		thread shootables_done();

		break;
	}

	trig_1 Delete();
	model_1 Delete();
}

function shootable_2()
{
	trig_2 = GetEnt("shootable_trig_2", "targetname");
	model_2 = GetEnt("shootable_model_2", "targetname");

	trig_2 SetHintString("");
	trig_2 SetCursorHint("HINT_NOICON");

	while(1)
	{
		trig_2 waittill("trigger");

		level.shootablesCollected++;

		IPrintLn("Trigger 2 Shot"); // Not Needed

		thread shootables_done();

		break;
	}

	trig_2 Delete();
	model_2 Delete();
}
function shootable_3()
{
    trig_3 = GetEnt("shootable_trig_3", "targetname");
	model_3 = GetEnt("shootable_model_3", "targetname");

	trig_3 SetHintString("");
	trig_3 SetCursorHint("HINT_NOICON");

	while(1)
	{
		trig_3 waittill("trigger");

		level.shootablesCollected++;

		IPrintLn("Trigger 1 Shot"); // Not Needed

		thread shootables_done();

		break;
	}

	trig_3 Delete();
	model_3 Delete();
}



function shootables_done()
{
door_power = GetEnt("door_power", "targetname");
	while(1)
	{
self waittill(level.shootablesCollected >= level.shootablesNeeded);

if(level.shootablesCollected == level.shootablesNeeded)
{
             door_power MoveZ(-100, 5);

             wait 5;

             door_power Delete();

		        break;
		}
	}
}

Haven't test this but it should work. Just do reckfullies tutoral at the top of the forum and just add one more script model with a targetname "shootable_model_3" and a trigger damage with the targetname "shootable_trig_3" then add your door make it a  script modle and add the targetname "door_power".  Finally, this should work but it will not say your entering the zone so if you want zombies to spawn in your power room you might have to have someone easle help you with that.

You must have messed something up when copying or something, the function I gave you shouldn't be causing this.

Check line 30 of that script and if you cant figure it out just post the whole script here and Ill look at it

Trying to get audio to play when a trigger has been shot tried everything. Sorta like the EE from The Giant.

EDIT: Figured it out

Add this to the top of the script:

#using scripts/zm/_zm_powerups;

Then add this to the shootable_done function:

level thread zm_powerups::specific_powerup_drop("powerupname", origin);

Just replace "powerupname" with the code name of the powerup.

Avaliable Powerups:

Spoiler: click to open...

• bonfire_sale
• carpenter
• double_points
• fire_sale
• free_perk
• full_ammo
• insta_kill
• shield_charge
• weapon_minigun
• ww_grenade

[close]

Then make origin the origin you want the powerup to spawn at.
Example:

test = GetEnt("test", "targetname");

level thread zm_powerups::specific_powerup_drop("full_ammo", test.origin); // This will spawn a max ammo at the origin of the test entity.

im getting this error?
^1}
^1^
^1ERR(6E) scripts/custom/shootable.gsc (157,1)  : Compiler Internal Error :  Unresolved external 'zm_powerups::specific_powerup_drop'

#using scripts\zm\zm_powerups;

im getting this error?
^1}
^1^
^1ERR(6E) scripts/custom/shootable.gsc (157,1)  : Compiler Internal Error :  Unresolved external 'zm_powerups::specific_powerup_drop'

#using scripts\zm\zm_powerups;

Wrong perk reference

It's the specialty name you must use

Think for widows it's either

"Specialty_widowswine"

If not its

"Specialty_widows_wine"

Check the zm_perks gsh for the list

The other you've used is just a variable

function shootables_done(player)
{
	while(1)
	{
		self waittill(level.shootablesCollected >= level.shootablesNeeded);
 
		if(level.shootablesCollected == level.shootablesNeeded)
		{
			players = GetPlayers();

			for(i=0; i < players.size; i++)
			{    
				player[i] zm_perks::give_perk( PERK_WIDOWS_WINE, false );
			}
		}
		break;
	}
}

I would just like to state that using PERK_WIDOWS_WINE will not affect the outcome. Also it is "specialty_widowswine" which is also defined by PERK_WIDOWS_WINE.

His problem was inside the loop.

function shootables_done(player)
{
	while(1)
	{
		self waittill(level.shootablesCollected >= level.shootablesNeeded);
 
		if(level.shootablesCollected == level.shootablesNeeded)
		{
			players = GetPlayers();

			for(i=0; i < players.size; i++)
			{    
				player[i] zm_perks::give_perk( PERK_WIDOWS_WINE, false );
			}
		}
		break;
	}
}

I have fixed the code so if you wish to replace the function you can do.

Also question for OP, out of curiosity why did you add a loop into shootables_done?

I would just like to state that using PERK_WIDOWS_WINE will not affect the outcome. Also it is "specialty_widowswine" which is also defined by PERK_WIDOWS_WINE.

His problem was inside the loop.

Spoiler: click to open...

function shootables_done(player)
{
	while(1)
	{
		self waittill(level.shootablesCollected >= level.shootablesNeeded);
 
		if(level.shootablesCollected == level.shootablesNeeded)
		{
			players = GetPlayers();

			for(i=0; i < players.size; i++)
			{    
				player[i] zm_perks::give_perk( PERK_WIDOWS_WINE, false );
			}
		}
		break;
	}
}

[close]

I have fixed the code so if you wish to replace the function you can do.

Also question for OP, out of curiosity why did you add a loop into shootables_done?